This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch for cfgloopmanip.c - misplaced semicolon
- From: Graham Stott <graham dot stott at btinternet dot com>
- To: law at redhat dot com
- Cc: Zdenek Dvorak <rakdver at atrey dot karlin dot mff dot cuni dot cz>, fnf at intrinsity dot com, gcc-patches at gcc dot gnu dot org
- Date: Wed, 05 Feb 2003 20:27:04 +0000
- Subject: Re: Patch for cfgloopmanip.c - misplaced semicolon
- References: <200302052006.h15K6TEK029382@localhost.redhat.com>
law@redhat.com wrote:
In message <20030205195751.GA17093@atrey.karlin.mff.cuni.cz>, Zdenek Dvorak wri
tes:
>Hello,
>
>> 2003-02-05 Fred Fish <fnf@intrinsity.com>
>>
>> * cfgloopmanip.c (force_single_succ_latches): Remove semicolon
>> that nullified intended for loop body.
>
>no, it is correct this way -- this loop just looks up the edge from
>latch.
Put the semicolon on the next line, properly indented. That will help
make it clear that the semicolon is intentional.
Also remove the misleading indentation from the following line.
jeff
Even better use continue which is more visible than just a semicolon
and add a blank line before the next statement. That way it's gives
a better visual clue.
Graham