This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH 3.3 0203 i386/{i386.c,{i386elf,ptx4-i,sysv4}.h} forUnixWare build failure.
- From: Zack Weinberg <zack at codesourcery dot com>
- To: rbrown64 at csc dot com dot au
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 04 Feb 2003 10:05:29 -0800
- Subject: Re: PATCH 3.3 0203 i386/{i386.c,{i386elf,ptx4-i,sysv4}.h} forUnixWare build failure.
- References: <OFC22DD56C.50A42F80-ONCA256CC3.00289E8B@int.csc.com.au>
rbrown64@csc.com.au writes:
> i386.h- Do not use this macro to indicate that structures and unions
> i386.h- should always be returned in memory. You should instead use
> i386.h- `DEFAULT_PCC_STRUCT_RETURN' to indicate this. */
> i386.h-
> i386.h:#define RETURN_IN_MEMORY(TYPE) \
> i386.h- ix86_return_in_memory (TYPE)
The comment is misleading. DEFAULT_PCC_STRUCT_RETURN is obsolete and
should not be used in new ports.
It appears to me that there is nothing wrong with the definition of
RETURN_IN_MEMORY that you deleted; however, ix86_return_in_memory does
the exact same thing when !TARGET_64BIT, so you should be able to
delete all the overrides without further action. What purpose did
this change serve?
> - fprintf (file, "\tmovl\t$%sP%d,%%$s\n", LPREFIX, labelno,
> + fprintf (file, "\tmovl\t$%sP%d,%%%s\n", LPREFIX, labelno,
> PROFILE_COUNT_REGISTER);
This bit qualifies as an obvious fix; I've checked it in for you on
mainline and the 3.3 branch.
zw