This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: fix Werror failures on alpha-linux
> From: Richard Henderson <rth@redhat.com>
>
> On Wed, Jan 22, 2003 at 12:48:03AM -0500, Kaveh R. Ghazi wrote:
> > causes a bootstrap failure if your stage1 compiler is cc because
> > -Wno-error is passed to the compiler without regard to whether or not
> > gcc is being used.
>
> Hmm.
>
> > I'm not sure why you went down this road in the first place, the
> > -Werror stuff is only used in stage2 or later and the fixincl stuff is
> > built in stage1. (Unless you set WERROR for a cross-compile?)
>
> Oh, I see what I did: I got errors in stage2, restarted from
> stage0, but with -Werror. I guess this could be reverted...
Done.
> > Perhaps the expansion is getting lost
> > when going into the fixinc Makefile.
>
> Exactly. AFAICT, fixinc.sh-warn would be expanded.
> r~
Let me see if I got this straight. We're getting the expansion in
WARN_CFLAGS in the gcc/Makefile rule for fixinc.sh when it does
WARN_CFLAGS="$(WARN_CFLAGS)" before it cd's into the fixinc directory?
Eww, yuck. :-)
I'd like to figure out how to fix this since the fixinc warnings are
preventing me from automatically activating -Werror in stage1.
Suggestion: instead of passing WARN_CFLAGS down through the rule for
fixinc.sh, we can instead set WARN_CFLAGS = @warn_cflags@ in
fixinc/Makefile.in just like we do for gcc/Makefile.in. Thoughts?
--Kaveh
--
Kaveh R. Ghazi ghazi@caip.rutgers.edu