This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] More PCH fixes
- From: Geoff Keating <geoffk at geoffk dot org>
- To: weigand at immd1 dot informatik dot uni-erlangen dot de
- Cc: weigand at immd1 dot informatik dot uni-erlangen dot de, gcc-patches at gcc dot gnu dot org
- Date: Fri, 17 Jan 2003 21:19:57 -0800
- Subject: Re: [PATCH] More PCH fixes
- References: <200301180207.DAA27614@faui11.informatik.uni-erlangen.de>
> From: Ulrich Weigand <weigand@immd1.informatik.uni-erlangen.de>
> Date: Sat, 18 Jan 2003 03:07:03 +0100 (MET)
> Cc: weigand@immd1.informatik.uni-erlangen.de (Ulrich Weigand),
> gcc-patches@gcc.gnu.org
> X-OriginalArrivalTime: 18 Jan 2003 02:06:38.0406 (UTC) FILETIME=[3C31BE60:01C2BE96]
>
> Geoff Keating wrote:
>
> > The idea seems good, but you can't have GTY-marked objects inside #if,
> > you have to move them outside.
>
> Sorry, I wasn't aware of that. Unfortunately, the easy way to do that
> will cause (yet more) warnings on platforms that disable (parts of)
> DWARF2 support, but I don't see a way to avoid this without using
> #if ...
It shouldn't add any warnings. All the variables _are_ used, even on
platforms that don't use dwarf2, because their addresses are taken
inside gengtype-generated code.
> Bootstrapped/regtested on s390-ibm-linux and s390x-ibm-linux.
> OK?
This is OK.
--
- Geoffrey Keating <geoffk@geoffk.org>