This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix toplevel configure for --target TARGET_NAME etc.


On Jan 16, 2003, Jakub Jelinek <jakub@redhat.com> wrote:

> On Thu, Jan 16, 2003 at 02:50:33PM -0200, Alexandre Oliva wrote:
>> On Jan 16, 2003, DJ Delorie <dj@delorie.com> wrote:
>> 
>> > 2003-01-16  Jakub Jelinek  <jakub@redhat.com>
>> 
>> > 	* configure.in (baseargs): Remove all supported forms of
>> > 	--cache-file, --srcdir, --host, --build and --target options
>> > 	from argument lists.
>> > 	* configure: Rebuilt.
>> 
>> > Ok.
>> 
>> Erhm...  Are you sure regexp alternation (\|) is portable sed?  I'm
>> not atm.

> If not, I'll have to spell the two alternatives on separate lines.

But why do you need the alternatives?  We've done without them
perfectly well.

> See what autoconf accepts, say for --cache-file:
>   -cache-file | --cache-file | --cache-fil | --cache-fi \
>   | --cache-f | --cache- | --cache | --cach | --cac | --ca | --c)
>     ac_prev=cache_file ;;
>   -cache-file=* | --cache-file=* | --cache-fil=* | --cache-fi=* \
>   | --cache-f=* | --cache-=* | --cache=* | --cach=* | --cac=* | --ca=* | --c=*)
>     cache_file="$ac_optarg" ;;

I see.  It must have been something about the old Cygnus configure,
then.  Perhaps some old option it used to accept that started with
--cach too.  No longer relevant.  The change from --cache to --c is
ok.  I still don't see the point of the alternations, except perhaps
for documentation purposes, but there's no reason to make the regular
expressions trickier to document the options; comments will do better.

-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                 aoliva@{redhat.com, gcc.gnu.org}
CS PhD student at IC-Unicamp        oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist                Professional serial bug killer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]