This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: libiberty: hashtab allocation functions with an extra argument

On Thu, Jan 16, 2003 at 11:06:41AM -0500, DJ Delorie wrote:
> 
> > Why not?  My patch already assumes that the presence or absence of the
> > argument (i.e. NULL-ness) determines which function to call.  Killing
> > the two extra function pointers is easy.
> 
> That means you can never call the new functions with an argument of
> NULL.  Is this really what you want?

For GDB's use, this is probably OK.  On the other hand, you're right,
it doesn't sound like a good design decision.  Maybe not.

And I'm wrong, too - my patch didn't assume this at all, it keyed off
which set of functions were specified when we created it.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]