This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch installed to remove PARAMS macro from java dir
> Date: Thu, 9 Jan 2003 23:17:15 -0500 (EST)
> From: "Kaveh R. Ghazi" <ghazi@caip.rutgers.edu>
> > From: Geoff Keating <geoffk@geoffk.org>
> >
> > "Kaveh R. Ghazi" <ghazi@caip.rutgers.edu> writes:
> >
> > > Note there are a few PARAMS left.
> > > Also there's one left in builtins.c. When I removed that one I ran
> > > into a bug (?) in gengtype. Something else to look at (later).
> >
> > It's not a bug; gengtype followed the previous coding conventions,
> > which says to expect a PARAMS. You could change it, but that's a
> > fairly big job because PARAMS is an easily distinguised token. I have
> > had to add more of these back while merging pch-branch.
>
> Does that mean we're stuck with a smattering of PARAMS forever?
No, it just means that you can't just delete them, you have to update
gengtype too. Maybe you could get away with using '(' as an
alternative to PARAMS, or maybe gengtype needs to be more of a full C parser.
> Maybe we could introduce a separate token for gengtype that cpp
> defines to be empty but gengtype can grok. Leaving it as PARAMS seems
> confusing down the road.
That sounds highly error-prone.
--
- Geoffrey Keating <geoffk@geoffk.org>