This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: improve vtable emission
- From: Mark Mitchell <mark at codesourcery dot com>
- To: Matt Austern <austern at apple dot com>, Nathan Sidwell <nathan at codesourcery dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 02 Jan 2003 18:09:40 -0800
- Subject: Re: PATCH: improve vtable emission
--On Thursday, January 02, 2003 01:40:35 PM -0800 Matt Austern
<austern@apple.com> wrote:
+#if 0
+ /* This would be nice, but we didn't think of it in time. */
+ || DECL_DESTRUCTOR_P (method)
+#endif
Remove this; as Geoff said, we don't believe in #if 0'd code.
+ if (CLASSTYPE_KEY_METHOD (t) == NULL_TREE)
+ {
+ keyed_classes = tree_cons (NULL_TREE, t, keyed_classes);
+ }
Remove the braces; we're not supposed to have them if there's only one
statement between them.
+ tree fnclass = DECL_CLASS_CONTEXT (fndecl);
You can just use DECL_CONTEXT here; you know it's a virtual member.
+ {
+ keyed_classes = tree_cons (NULL_TREE, fnclass, keyed_classes);
+ }
Extra braces again.
With those minor changes, the patch is fine.
--
Mark Mitchell mark@codesourcery.com
CodeSourcery, LLC http://www.codesourcery.com