This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Java: fixes for -fno-assume-compiled
- From: Tom Tromey <tromey at redhat dot com>
- To: Jeff Sturm <jsturm at one-point dot com>
- Cc: java-patches at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: 16 Dec 2002 10:27:05 -0700
- Subject: Re: Java: fixes for -fno-assume-compiled
- References: <Pine.LNX.4.44.0212141313200.22899-100000@ops2.one-point.com>
- Reply-to: tromey at redhat dot com
>>>>> "Jeff" == Jeff Sturm <jsturm@one-point.com> writes:
I don't really have a problem with this patch.
Jeff> + // If superclass looks like a constant pool entry,
Jeff> + // resolve it now.
Jeff> + if ((int) klass->superclass < pool->size)
Jeff> + klass->superclass = pool->data[(int) klass->superclass].clazz;
Yuck.
Both sides of the comparison should be unsigned, shouldn't they?
Could we add a flag somewhere instead?
Tom