This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch: fix crash on legal code
- From: Dale Johannesen <dalej at apple dot com>
- To: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- Cc: Dale Johannesen <dalej at apple dot com>, rth at redhat dot com, gcc-patches at gcc dot gnu dot org
- Date: Thu, 12 Dec 2002 18:24:40 -0800
- Subject: Re: Patch: fix crash on legal code
On Thursday, December 12, 2002, at 06:04 PM, Kaveh R. Ghazi wrote:
The testcase for this which you installed as gcc.dg/20021205-1.c
appears to be failing on all LP64 targets. E.g. ia64, mips -mabi=64,
sparc64, mmix, alpha, etc.
Sorry! Your changes look fine.
1. Was there something about the thing you were trying to test that
precluded declaring baz()?
No, just tried to get it as small as possible. Too small.
2. Was there a reason this test wasn't put in gcc.c-torture/compile?
Putting stuff there for tests that don't need special flags beyond
opt levels is usually better (There's an -O3 pass included if you
needed that to trigger the error.)
Ignorance; I've never found any docs about what tests to put where.
Why is it better?
Assuming no objections, I'd like to move the test into the torture
framework and add the declaration. Something like what I have below.
OK with me (actually I'll do it if you'd prefer). I have no authority,
but I suppose this qualifies as obvious.