This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [3.4-BIB] i386 condtiional moves cleanup I
- From: Jan Hubicka <jh at suse dot cz>
- To: Andreas Jaeger <aj at suse dot de>
- Cc: Jan Hubicka <jh at suse dot cz>, gcc-patches at gcc dot gnu dot org, rth at cygnus dot com
- Date: Mon, 2 Dec 2002 00:57:40 +0100
- Subject: Re: [3.4-BIB] i386 condtiional moves cleanup I
- References: <20021201163708.GO31553@kam.mff.cuni.cz> <u8y9797j5w.fsf@gromit.moeb>
>
> Just two comments regarding comments:
>
> Jan Hubicka <jh@suse.cz> writes:
>
> > [...]
> > ! /* Expand code to set REAL_OUT into CT when (CODE OP0 OP1) is true, cf
> > ! otehrwise. */
>
> otherwise.
I will fix that in my local copy, thank!
> > [...]
> > ! if (compare_code != NIL)
> > ! {
> > ! /* notl op1 (if needed)
> > ! sarl $31, op1
> > ! andl (cf-ct), op1
> > ! addl ct, op1
> > !
> > ! For x < 0 (resp. x <= -1) there will be no notl,
>
> notl?
I didn't wrote that comment, but notl is opcode...
Honza
>
> > ! so if possible swap the constants to get rid of the
> > ! complement.
> > ! True/false will be -1/0 while code below (store flag
> > ! followed by decrement) is 0/-1, so the constants need
> > ! to be exchanged once more. */
>
> Andreas
> --
> Andreas Jaeger
> SuSE Labs aj@suse.de
> private aj@arthur.inka.de
> http://www.suse.de/~aj