This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] PR c/7490
- From: Gabriel Dos Reis <gdr at integrable-solutions dot net>
- To: Philippe Trebuchet <Philippe dot Trebuchet at sophia dot inria dot fr>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: 20 Nov 2002 23:38:33 +0100
- Subject: Re: [Patch] PR c/7490
- Organization: Integrable Solutions
- References: <3DDC0C8A.784F9825@sophia.inria.fr>
Philippe Trebuchet <Philippe.Trebuchet@sophia.inria.fr> writes:
| I propose to add the checking in genrtl_stmt_scope delaying thus as far
| as possible those checks. I experienced no regressions.
Editorial comments:
| ! else
| ! if (DECL_SAVED_INSNS (fn) != NULL)
This reads easier as "else if "
[...]
| ! error("no definition for auto nested function %s"
^ ^^
needs spacing and quote.
| ! ,IDENTIFIER_POINTER (DECL_NAME (fn)));
^
I think the comma should go on the preceding line.
I would really like us not to peek directly at IDENTIFIER_POINTER of
decls, but I guess that is for 3.4.
Your patch is missing a testcase, preferably put under gcc.dg/.
I wish gcc.dg/ were structured like g++.dg/ with different directories
for definite categories of tests...
-- Gaby