This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Unreviewed patches


On 19 Nov 2002, Geoff Keating wrote:
> The warning for the case when only one is not supported would have
> better grammar if it read
>
> "warning: -fpic is not supported"
>
> If you could change the regexp to match this, the patch is OK.

Thanks for the review.

It's both -fpic and -fPIC anyway for all cases I know of (it
should be, anyway), it's just printed only for the specified
option.  This is what I'll commit once I get a chance to test
it.

	* lib/prune.exp: Prune more -fpic/-fPIC warnings.

Index: prune.exp
===================================================================
RCS file: /cvs/gcc/gcc/gcc/testsuite/lib/prune.exp,v
retrieving revision 1.8
diff -p -c -r1.8 prune.exp
*** prune.exp	2 Oct 2002 20:01:38 -0000	1.8
--- prune.exp	20 Nov 2002 13:02:35 -0000
*************** proc prune_gcc_output { text } {
*** 24,31 ****
      regsub -all "(^|\n)collect2: ld returned \[^\n\]*" $text "" text
      regsub -all "(^|\n)Please submit.*instructions\[^\n\]*" $text "" text

!     # Ignore harmless -fpic warnings on cygwin.
      regsub -all "(^|\n)\[^\n\]*: warning: -f(pic|PIC) ignored for target\[^\n\]*" $text "" text

      # It would be nice to avoid passing anything to gcc that would cause it to
      # issue these messages (since ignoring them seems like a hack on our part),
--- 24,32 ----
      regsub -all "(^|\n)collect2: ld returned \[^\n\]*" $text "" text
      regsub -all "(^|\n)Please submit.*instructions\[^\n\]*" $text "" text

!     # Ignore harmless -fpic warnings.
      regsub -all "(^|\n)\[^\n\]*: warning: -f(pic|PIC) ignored for target\[^\n\]*" $text "" text
+     regsub -all "(^|\n)\[^\n\]*: warning: -f(pic|PIC)( and -fpic are| is)? not supported\[^\n\]*" $text "" text

      # It would be nice to avoid passing anything to gcc that would cause it to
      # issue these messages (since ignoring them seems like a hack on our part),

brgds, H-P


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]