This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix PR 8639 (3.2.1 material)


Christian Ehrhardt wrote:-

> --- gcc-3.2.1-20021111/gcc/fold-const.c.orig	Tue Nov 19 18:47:57 2002
> +++ gcc-3.2.1-20021111/gcc/fold-const.c	Tue Nov 19 18:57:04 2002
> @@ -4617,10 +4617,12 @@
>        t2 = extract_muldiv (op1, c, code, wide_type);
>        if (t1 != 0 && t2 != 0
>  	  && (code == MULT_EXPR
> -	      /* If not multiplication, we can only do this if either operand
> -		 is divisible by c.  */
> -	      || multiple_of_p (ctype, op0, c)
> -	      || multiple_of_p (ctype, op1, c)))
> +	      /* If not multiplication, we can only do this if this is 
> +	       * PLUS_EXPR and both operands are divisible by c. Note that
> +	       * (80 - 4*x)/20 or (80 + (-4)*x)/20 must not degenerate
> +	       * into (20 - x/5). */
> +	      || (multiple_of_p (ctype, op0, c) &&
> +	          multiple_of_p (ctype, op1, c))))

Please following the coding style of the surrounding code; && goes on
the new line.

Neil.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]