This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Add make_relative_prefix to libiberty
- From: DJ Delorie <dj at redhat dot com>
- To: drow at mvista dot com
- Cc: gcc-patches at sources dot redhat dot com
- Date: Mon, 18 Nov 2002 14:44:38 -0500
- Subject: Re: Add make_relative_prefix to libiberty
- References: <20021118174038.GA12204@nevyn.them.org>
> 2002-11-18 Daniel Jacobowitz <drow@mvista.com>
>
> * libiberty.h (make_relative_prefix): Add prototype.
>
> 2002-11-18 Daniel Jacobowitz <drow@mvista.com>
>
> * Makefile.in: Add make-relative-prefix.c.
> * make-relative-prefix.c: New file.
You're creating an obstack which will become impossible to clean up
after. Please just call malloc (not xmalloc). Return NULL on
allocation failure. Please note the allocation rules in the header.
Please regenerate the documentation from the source. Please check for
valid (i.e. non-NULL arguments). The comment "Determine if the
compiler is installed in the standard location" would no longer be
appropriate. You may not call xmalloc or friends from any of these
functions, you must instead signal an allocation error to the
application somehow.
You have also changed the copyright terms (GPL -> LGPL). Do you have
the FSF's permission to do so?
> 2002-11-18 Daniel Jacobowitz <drow@mvista.com>
>
> * gcc.c (make_relative_prefix): Remove.
> (free_split_directores, split_directories): Remove.
I can't approve the gcc changes, of course.