This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Toplevel patch: Autogenerate Makefile targets 2 (*-target-*)


> 	* Makefile.tpl: Autogenerate *-target-* targets.
> 	* Makefile.in: Regenerate.

> -	@dir=`echo $@ | sed -e 's/configure-target-//'`; \
> +	dir=[+module+] ; \

You dropped the '@' here.  The '@' is a make thing, not part of the
scriptlet.

> -$(ALL_TARGET_MODULES):
> -	@dir=`echo $@ | sed -e 's/all-target-//'`; \
> -	if [ -f $(TARGET_SUBDIR)/$${dir}/Makefile ] ; then \
> +.PHONY: all-target-[+module+]
> +all-target-[+module+]:
> +	dir=[+module+] ; \

'@' here.

> -$(CHECK_TARGET_MODULES):
> -	@dir=`echo $@ | sed -e 's/check-target-//'`; \
> -	if [ -f $(TARGET_SUBDIR)/$${dir}/Makefile ] ; then \
> +[+ IF no_check +][+ ELSE check +]

Is this the best place for this IF?

> +.PHONY: check-target-[+module+]
> +check-target-[+module+]:
> +	dir=[+module+] ; \

'@' here.

> -$(INSTALL_TARGET_MODULES): installdirs
> -	@dir=`echo $@ | sed -e 's/install-target-//'`; \
> -	if [ -f $(TARGET_SUBDIR)/$${dir}/Makefile ] ; then \
> +[+ ENDIF no_check +]

This endif looks out of place.

> +[+ IF no_install +][+ ELSE install +]\
> +.PHONY: install-target-[+module+]
> +install-target-[+module+]: installdirs
> +	dir=[+module+] ; \

'@' here.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]