This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [PATCH] for gcc/testsuite/gcc.dg/20020219-1.c
- From: "D.Venkatasubramanian, Noida" <dvenkat at noida dot hcltech dot com>
- To: Richard Henderson <rth at redhat dot com>
- Cc: "'gcc at gcc dot gnu dot org'" <gcc at gcc dot gnu dot org>, "'gcc-patches at gcc dot gnu dot org'" <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 10 Oct 2002 12:25:51 +0530
- Subject: RE: [PATCH] for gcc/testsuite/gcc.dg/20020219-1.c
> -----Original Message-----
> From: Richard Henderson [mailto:rth@redhat.com]
> Sent: Thursday, October 10, 2002 3:13 AM
> To: D.Venkatasubramanian, Noida
> Cc: 'gcc@gcc.gnu.org'; 'gcc-patches@gcc.gnu.org'
> Subject: Re: [PATCH] for gcc/testsuite/gcc.dg/20020219-1.c
>
>
> On Wed, Oct 09, 2002 at 02:06:46PM +0530,
> D.Venkatasubramanian, Noida wrote:
> > On investigation, I found an array a being declared
> > the size of which is too large for the 16 bit target.
> > When I supply -mh -mint32, it works fine. By this patch,
> > I preclude H8300 16 bit targets.
>
> So why does your patch mention H8 at all, instead of
> disabling this test for all 16 bit targets?
>
>
> r~
>
In the patch, I have tried to identify the 16-bit target
through the INT_MAX macro. If I had done #if INT_MAX < 32767,
then I could have precluded all targets with 16 bit integers.
I didn't do it as, atleast theoretically, some target may have
16 bit integers, while having say, a 32-bit address sizes (though,
I do really think this is higly impossible). So,this test case
shouldn't be disabled for such targets. On the other side of the
coin, again, a 32 bit integer and 16 bit address size is possible.
I precluded H8 only, as these weren't the case here.
The problem lies in an array of 200 / 400 MB being created in the
test case.
Please tell me #if INT_MAX < 32767 is OK. I will resubmit the changed
patch.
Thanks and Regards,
Venky