This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: "Obvious" change in cp/decl.c
- From: Matt Austern <austern at apple dot com>
- To: Mark Mitchell <mark at codesourcery dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 2 Oct 2002 10:33:55 -0700
- Subject: Re: "Obvious" change in cp/decl.c
On Tuesday, October 1, 2002, at 06:25 PM, Mark Mitchell wrote:
--On Tuesday, October 01, 2002 04:23:23 PM -0700 Matt Austern
<austern@apple.com> wrote:
I claim that this is an obvious patch:
Index: decl.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/cp/decl.c,v
retrieving revision 1.939
diff -u -r1.939 decl.c
--- decl.c 1 Oct 2002 18:27:53 -0000 1.939
+++ decl.c 1 Oct 2002 23:18:06 -0000
@@ -1793,7 +1793,7 @@
int result = 0;
for (; decl ; decl = TREE_CHAIN (decl))
- result != (*f) (&decl, d);
+ result |= (*f) (&decl, d);
return result;
}
Any disagreement?
This patch is OK, as long as the tests pass.
Done! It doesn't introduce any new failures. To my mild
disappointment,
it also don't fix any existing failures in the test suite.
--Matt