This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fixing PR fortran/3924.


Richard Henderson wrote:

> On Sun, Sep 15, 2002 at 03:08:21PM +0200, Toon Moene wrote:

> >         if (GET_CODE (value) == MEM
> > -       && GET_CODE (XEXP (value, 0)) == SYMBOL_REF)
> > +       && GET_CODE (XEXP (value, 0)) == SYMBOL_REF
> > +           && GET_CODE (XEXP (XEXP (value, 0), 0) != PLUS
> > +           && GET_CODE (XEXP (XEXP (value, 0), 0) != MINUS)

> This isn't right.  The only argument for SYMBOL_REF
> is XSTR (blah, 0), which is a string.  A PLUS/MINUS
> would have to come elsewhere.  E.g.

Duh! So a bootstrap would have failed with rtl-checking on ...

[ ... obscure case further down ... ]

Yes, I looked at that part, too, but found the comment too forbidding
;-)

Thanks for fixing this !

--
Toon Moene, KNMI, PO Box 201, 3730 AE De Bilt, The Netherlands.
Tel. +31302206443, Fax +31302210407,  e-mail moene@knmi.nl
URL: http://www.knmi.nl/hirlam
--------------------------------------------------------------
Zie ook/see also: http://www.knmi.nl/maildisclaimer.html 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]