Re: MIPS: Always emit "dla" for loading DImode addresses

["Maciej W. Rozycki" <macro at ds2 dot pg dot gda dot pl>]

On 16 Sep 2002 cgd@broadcom.com wrote:

> > 2002-09-16  Maciej W. Rozycki  <macro@ds2.pg.gda.pl>
> > 
> > 	* config/mips/mips.md (call_value_multiple_internal2): Emit a 
> > 	"dla" for loading a DImode address.
> > 	(leadi): Ditto.
> 
> Good to see somebody else has noticed this (and, in more places than I
> did)...  I sent the following patch last February:

 Well, I found the call_value_multiple_internal2 case after proof-reading
the file just in case when gas complained about the leadi one.

> 	http://gcc.gnu.org/ml/gcc-patches/2002-02/msg01250.html
> 
> but nothing ever happened with it and I mostly forgot about it.  (it
> was on my "Big List of Pending Patches," but i didn't make time to
> ping... and it was fixed in my sources.  8-)

 Your concerns about Irix are likely unnecessary -- "dla" is used
everywhere else for DImode addresses, so an incompatibility would be
spotted long ago. 

> Maciej, do you have any other test cases that would show the problem?
> 
> I like mine, but I don't know that it's the best one in the world...
> a test case that used a 'normal' 64-bit ABI would be better.  8-)
> (assuming none others are fortcoming, Eric, permission to check in
> that one once i verify that it still "works"?)

 No other test cases -- it just happened to get triggered by mm/mmap.c in
Linux.  Since the change seems obvious and the code generated by gas
doesn't differ I didn't bother myself to cook up a test case, sorry.

  Maciej

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +