This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH for 3.2] Make PDP-11 port compilable


On Tue, Sep 10, 2002 at 10:18:01PM +0900, Naohiko Shimizu wrote:
> +/*
> + * 4th Sep. 2002, Naohiko Shimizu <nshimizu@keyaki.cc.u-tokai.ac.jp>
> + * Resolve some compile errors for pdp11.
> + * I tested with
> + *   configure --target=pdp11-none-aout --with-included-gettext
> + *   make LANGUAGES=c
> + * Any comment will be welcome.
[...]
> +/*
> + * 4th Sep. 2002, Naohiko Shimizu <nshimizu@keyaki.cc.u-tokai.ac.jp>
> + * Resolve some compile errors for pdp11.
> + * I tested with
> + *   configure --target=pdp11-none-aout --with-included-gettext
> + *   make LANGUAGES=c
> + * Any comment will be welcome.
> + * 6th Sep.2002, GO_IF_LEGITIMATE_ADDRESS modified with Paul Koning's code.
[...]
> +;; 
> +;;  10th Sep. 2002, Naohiko Shimizu <nshimizu@keyaki.cc.u-tokai.ac.jp>
> +;;     newlib-1.10 can be compiled with -mint32 or -mint16
> +;;   5th Sep. 2002, Naohiko Shimizu <nshimizu@keyaki.cc.u-tokai.ac.jp>
> +;;     correct some part with the indication by Paul Koning.
> +;;
> +;;   4th Sep. 2002, Naohiko Shimizu <nshimizu@keyaki.cc.u-tokai.ac.jp>
> +;;   Resolve some compile errors for pdp11.
> +;;   I tested with
> +;;     configure --target=pdp11-none-aout --with-included-gettext
> +;;     make LANGUAGES=c
> +;;   Any comment will be welcome.

Such comments should never be added.

The ChangeLog entry needs to follow proper GNU coding
standards.

The patch itself looks largely ok, to someone who doesn't
speak pdp11.


r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]