This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH RFC: dwarf2 EH for Darwin
- From: Jason Merrill <jason at redhat dot com>
- To: Stan Shebs <shebs at apple dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 10 Sep 2002 10:50:14 +0100
- Subject: Re: PATCH RFC: dwarf2 EH for Darwin
- References: <3D7D3102.9050801@apple.com>
On Mon, 09 Sep 2002 16:38:42 -0700, Stan Shebs <shebs@apple.com> wrote:
> The first is the macro ASM_OUTPUT_DWARF_DELTA, which seems like
> it probably ought to be a target hook, even though it only needs
> a non-default value for the one target.
The comment at the beginning of dw2_asm_output_delta seems relevant. Why
does your implementation work for Darwin, when that comment suggests it
shouldn't?
> The second is the TERMINATE_EH_FRAME_INFO, which looks kludgy to
> me, but I'm not clear on how this ought to be done. The crux of
> the problem is that EH_FRAME_SECTION_NAME should not be set for
> Darwin, because it enables ELFish bits we don't really want.
> Perhaps the zero-termination choice ought to be a generic target
> hook too?
It's already kludgy; this should have been handled better when the target
hook for eh_frame_section was added.
One option would be to terminate it only if targetm.eh_frame_section is
still set to the default function. Speaking of which, it probably makes
sense to have two different default functions, depending on whether or not
EH_FRAME_SECTION_NAME is defined.
Jason