This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch to provide a default for ASM_OUTPUT_INTERNAL_LABEL
> From: Richard Henderson <rth@redhat.com>
>
> On Thu, Aug 22, 2002 at 01:36:09PM -0400, Kaveh R. Ghazi wrote:
> > Also in a few cases, the OUTPUT and GENERATE macros were slightly
> > different ...
>
> It wouldn't bother me at all if OUTPUT was in fact *not* implemented
> as a target hook, but instead as a mere function that calls the
> GENERATE and ASM_OUTPUT_LABEL hooks.
What about cases where the OUTPUT function needs to do something
beyond that? See this patch (which you approved) where there are
several target exceptions.
http://gcc.gnu.org/ml/gcc-patches/2002-08/msg01443.html
> Any time we can eliminate the possibility for mismatch like this
> seems like a Good Thing.
I totally agree. The default OUTPUT hook does exactly that. In all
but two (probably obsolete port) cases, the target OUTPUT hooks do
their custom bits and then call the default one. So there's very
little chance of mismatch. (And obviously less so than before I
introduced the hooks.)
--Kaveh
--
Kaveh R. Ghazi ghazi@caip.rutgers.edu