Re: [tree-ssa mudflap] source file/line locations

["Frank Ch. Eigler" <fche at redhat dot com>]

Hi -


rth wrote:
> On Wed, Aug 21, 2002 at 03:54:42PM -0400, Frank Ch. Eigler wrote:
> > +/* And another friend, for producing a simpler message.  */
> > +static tree
> > +mf_file_function_line_tree (file, line)
> > +     const char * file;
> > +     int line;
> 
> You'd probably be better off keeping file and line separate, as
> that'll use less space in the excutable.  

Trouble is that having the source/line pair is the most directly
helpful way to pinpoint each offending access attempt.


> As-is you'll have hordes of
> 	"longfilename.c:1 (foo)"
> 	"longfilename.c:2 (foo)"
> 	"longfilename.c:3 (foo)"
> instead of
> 	"longfilename.c"
> 	"foo"

That's true - it's simple but not very economical.


> and some extra code for pushing the new arguments to the runtime.

What's the alternative?  At this point, a single location string
is given to each __mf_check call.


- FChE