Re: [libobjc] fix to nil_method

[Stan Shebs <shebs at apple dot com>]

Hmmm, interesting.  I'm guessing that the bug is probably in how ObjC
semantics produce the call to nil_method - going by past experience,
it's probably being sloppy with decl nodes somewhere and not preserving
variadicity properly.  In theory, I could try to debug by comparing
cross compiler output, but I'm not sure what the desired code should
look like (your patch tweaking library internals rather than the
test program).

Stan

Jan Hubicka wrote:

> > Jan Hubicka <jh@suse.cz> writes:
> >
> > > > Jan Hubicka wrote:
> > > >
> > > > > The testcase I've seen simply calls nil_method with nonvariadic
> > > > > prototype, I am sure.
> > > > > I am not quite sure how the nil_method calls are constructed,
> > > > > so perhaps it is time to reconsider.  The testcase was called mbcopy.m
> > > > > if I recall directly.
> > > > I don't see a testcase mbcopy.m in our testsuite, and Google's never
> > > > heard of it either, so I'd like to get a look at it.
> > > Sorry, searching the testsuite, I am pretty sure it was the testcase
> > > bycopy-?.m and np-?.m, unfortunately I am not certain about the number.
> > >
> > > Andreas, I sent you list of failing testcases having just two of them,
> > > can you please forward it to Stan?
> > I guess this is what you were asking for:
> Yes, that is. All the failures goes away after applying my patch.
>
> Honza
>
> > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > Using /home/jh/share/dejagnu/baseboards/unix.exp as board description file for target.
> > Using /home/jh/share/dejagnu/config/unix.exp as generic interface file for target.
> > Using /abuild/jh/egcs/gcc/testsuite/config/default.exp as tool-and-target-specific interface file.
> > Running /abuild/jh/egcs/gcc/testsuite/objc/compile/compile.exp ...
> > Running /abuild/jh/egcs/gcc/testsuite/objc/execute/execute.exp ...
> > FAIL: objc/execute/bycopy-1.m execution,  -O0
> > FAIL: objc/execute/bycopy-1.m execution,  -O1
> > FAIL: objc/execute/bycopy-1.m execution,  -O2
> > FAIL: objc/execute/bycopy-1.m execution,  -O3 -fomit-frame-pointer
> > FAIL: objc/execute/bycopy-1.m execution,  -O3 -g
> > FAIL: objc/execute/bycopy-1.m execution,  -Os
> > FAIL: objc/execute/np-1.m execution,  -O0
> > FAIL: objc/execute/np-1.m execution,  -O1
> > FAIL: objc/execute/np-1.m execution,  -O2
> > FAIL: objc/execute/np-1.m execution,  -O3 -fomit-frame-pointer
> > FAIL: objc/execute/np-1.m execution,  -O3 -g
> > FAIL: objc/execute/np-1.m execution,  -Os
> > Running /abuild/jh/egcs/gcc/testsuite/objc.dg/dg.exp ...
> > FAIL: objc.dg/desig-init-1.m execution test
> > Running /abuild/jh/egcs/gcc/testsuite/objc.dg/special/special.exp ...
> > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> > Andreas
> > --
> > Andreas Jaeger
> >  SuSE Labs aj@suse.de
> >   private aj@arthur.inka.de
> >    http://www.suse.de/~aj