Re: How to check that selectors exist

[Nicola Pero <nicola at brainstorm dot co dot uk>]

> >Here is a set of patches implementing -Wundeclared-selector as promised.
> >
> >NB: I will be leaving for two weeks on saturday (holidays finally :-).  
> >If Stan approves it when I'm away, I'm happy with anyone else applying it
> >(including any sort of reformatting and improvements which might be
> >necessary).  Else, I'll apply it if approved before I leave (which I
> >doubt, given how slow Stan is in approving :-), or when I am back.
> >
> Just for that :-), here's the OK.  (modulo a couple nits)

Thanks - back to work and I see CVS is now in stage 3 - is it ok to commit
this change still ?  It looks absolutely harmless to me (and of very
limited impact), and was approved when still in stage 2, but it can wait.

 
> >+/*
> >+ * This function is called by the parser when a @selector() expression
> >+ * is found, in order to compile it.  It is only called by the parser
> >+ * and only to compile a @selector().
> >+ */
> >
> The usual style is not to have leading '*' in comment blocks.

Ok

 
> >
> >+	  warning ("unknown (undeclared) selector `%s'", 
> >+		   IDENTIFIER_POINTER (selname));
> >
> I suggest phrasing this as just "undeclared selector `%s'".

Thanks - good suggestion - will change


> Also, you need to document it in doc/invoke.texi,

Thanks - I'll be happy to document it after applying it :-)