This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RFC: linkage patch to mips.c
- From: Jason Merrill <jason at redhat dot com>
- To: gcc-patches at gcc dot gnu dot org
- Date: Mon, 19 Aug 2002 13:24:53 +0100
- Subject: RFC: linkage patch to mips.c
In a patch of 2002-05-16, I added this check to work around a bug with RTTI
info. Nathan later fixed the bug properly, but I forgot to remove this
hack. I fear that removing it now would break ABI compatibility on MIPS
targets; new code that expects small comdats to be in sdata would fail to
link against old code that doesn't put them there.
Phooey. Thoughts?
2002-08-19 Jason Merrill <jason@redhat.com>
* config/mips/mips.c (mips_output_external): Don't check DECL_COMDAT.
*** gcc/config/mips/mips.c.~1~ Wed Aug 14 22:33:08 2002
--- gcc/config/mips/mips.c Thu Aug 1 23:00:31 2002
*************** mips_output_external (file, decl, name)
*** 5854,5860 ****
if (TARGET_GP_OPT
&& TREE_CODE (decl) != FUNCTION_DECL
- && !DECL_COMDAT (decl)
&& (len = int_size_in_bytes (TREE_TYPE (decl))) > 0
&& ((section_name = DECL_SECTION_NAME (decl)) == NULL
|| strcmp (TREE_STRING_POINTER (section_name), ".sbss") == 0
--- 5854,5859 ----