This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: GCC 3.2 suddenly fails every java test, CLASSPATH wrong
- From: "H. J. Lu" <hjl at lucon dot org>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: Mark Wielaard <mark at klomp dot org>,"Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>, gcc at gcc dot gnu dot org,java at gcc dot gnu dot org, mark at codesourcery dot com, gcc-patches at gcc dot gnu dot org
- Date: Fri, 16 Aug 2002 10:24:38 -0700
- Subject: Re: PATCH: GCC 3.2 suddenly fails every java test, CLASSPATH wrong
- References: <200208151501.LAA02954@caip.rutgers.edu> <20020815080552.A16501@lucon.org> <1029437565.15747.13.camel@elsschot> <20020815121359.A20307@lucon.org> <8765yazq2c.fsf@fleche.redhat.com>
On Fri, Aug 16, 2002 at 11:11:39AM -0600, Tom Tromey wrote:
> >>>>> "H.J." == H J Lu <hjl@lucon.org> writes:
>
> H.J.> "make install" shouldn't be required. It is a bug.
>
> I agree.
>
> - # Determine the version so we can find the libgcj jar file.
> - set text [eval exec "$GCJ_UNDER_TEST --version 2>@ stdout"]
> - regexp -- "gcj \[^ \]+ (\[^ \]+) .*" $text ignore gcc_version
> - verbose "jar file is libgcj-$gcc_version.jar"
> + # Find the libgcj jar file.
> + set libgcj_jar [eval exec "find $objdir/../ -name \"libgcj-*.jar\" 2>@ stdout"]
> + verbose "jar file is $libgcj_jar"
>
> I don't really like this hunk. I'd rather we not use `find' in the
> test suite.
>
> What is the problem here? Why doesn't the existing code work?
http://gcc.gnu.org/ml/gcc/2002-08/msg00901.html
>
> If it can't be made to work (I'd like to understand why first), let's
> use the Tcl glob command instead of `exec find'.
>
I don't know much about tcl. But I have no problems with that as long
as it works.
H.J.