This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: Follow up to my earlier patch (MIPS/Alpha/Interix)

From: Stan Shebs <shebs at apple dot com>
To: Ziemowit Laski <zlaski at apple dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Sat, 10 Aug 2002 09:51:33 -0700
Subject: Re: PATCH: Follow up to my earlier patch (MIPS/Alpha/Interix)
References: <B799D418-AC28-11D6-B439-00039390FFE2@apple.com>

Ziemowit Laski wrote:

Thanks to the regression checker, I discovered that my earlier patch
which eliminated clk_objective_c caused the MIPS bootstrap to fail
(see below).  Looking at the config/ subdirectories, I noticed that
at least two other targets will likely have problems.  Below,
I offer a patch for all three.  Presumably, the maintainers of the
respective back-ends should check this in, but I can do it as
well, if such is the will of the people.

Go ahead and check these in please.  Whenever I remove something,
I always do a grep -r in the whole GCC tree; it's remarkable what odd
bits have found their way into the sources over the years.

Stan

Index: gcc/config/mips/mips.h
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/mips/mips.h,v
retrieving revision 1.211
diff -c -3 -p -r1.211 mips.h
*** gcc/config/mips/mips.h 7 Aug 2002 02:57:53 -0000 1.211
--- gcc/config/mips/mips.h 10 Aug 2002 06:06:14 -0000
*************** extern void sbss_section PARAMS ((void)
*** 488,494 ****
builtin_define ("__LANGUAGE_C_PLUS_PLUS"); \
builtin_define ("__LANGUAGE_C_PLUS_PLUS__"); \
} \
! else if (c_language == clk_objective_c) \
{ \
builtin_define ("_LANGUAGE_OBJECTIVE_C"); \
builtin_define ("__LANGUAGE_OBJECTIVE_C"); \
--- 488,494 ----
builtin_define ("__LANGUAGE_C_PLUS_PLUS"); \
builtin_define ("__LANGUAGE_C_PLUS_PLUS__"); \
} \
! if (flag_objc) \
{ \
builtin_define ("_LANGUAGE_OBJECTIVE_C"); \
builtin_define ("__LANGUAGE_OBJECTIVE_C"); \

Index: gcc/config/i386/i386-interix.h
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/i386/i386-interix.h,v
retrieving revision 1.35
diff -c -3 -p -r1.35 i386-interix.h
*** gcc/config/i386/i386-interix.h 5 Aug 2002 18:53:16 -0000 1.35
--- gcc/config/i386/i386-interix.h 10 Aug 2002 06:14:04 -0000
*************** Boston, MA 02111-1307, USA. */
*** 72,78 ****
builtin_define_std ("LANGUAGE_C"); \
if (c_language == clk_cplusplus) \
builtin_define_std ("LANGUAGE_C_PLUS_PLUS"); \
! else if (c_language == clk_objective_c) \
builtin_define_std ("LANGUAGE_OBJECTIVE_C"); \
} \
} \
--- 72,78 ----
builtin_define_std ("LANGUAGE_C"); \
if (c_language == clk_cplusplus) \
builtin_define_std ("LANGUAGE_C_PLUS_PLUS"); \
! if (flag_objc) \
builtin_define_std ("LANGUAGE_OBJECTIVE_C"); \
} \
} \

Index: gcc/config/i386/i386-interix.h
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/i386/i386-interix.h,v
retrieving revision 1.35
diff -c -3 -p -r1.35 i386-interix.h
*** gcc/config/i386/i386-interix.h 5 Aug 2002 18:53:16 -0000 1.35
--- gcc/config/i386/i386-interix.h 10 Aug 2002 06:15:47 -0000
*************** Boston, MA 02111-1307, USA. */
*** 72,78 ****
builtin_define_std ("LANGUAGE_C"); \
if (c_language == clk_cplusplus) \
builtin_define_std ("LANGUAGE_C_PLUS_PLUS"); \
! else if (c_language == clk_objective_c) \
builtin_define_std ("LANGUAGE_OBJECTIVE_C"); \
} \
} \
--- 72,78 ----
builtin_define_std ("LANGUAGE_C"); \
if (c_language == clk_cplusplus) \
builtin_define_std ("LANGUAGE_C_PLUS_PLUS"); \
! if (flag_objc) \
builtin_define_std ("LANGUAGE_OBJECTIVE_C"); \
} \
} \

Begin forwarded message:

From: GCC regression checker <regress@redhat.com>
Date: Fri Aug 09, 2002 10:34:44 US/Pacific
To: gcc-regression@gcc.gnu.org
Cc: zlaski@apple.com
Subject: GCC build failed for mips-elf with your patch on 2002-08-10T02:30:00Z.
Reply-To: gcc-regression@gcc.gnu.org

With your recent patch, GCC does not compile on:
mips-elf
Attached is build output for those targets.

The build failures are new.

For more information, see <http://people.redhat.com/geoffk/gcc-regression/>.
------------------------------------------------------------------------

/maat/heart/tbox/cvs-gcc/gcc/gcc/c-pretty-print.c: In function `pp_c_integer_literal':
/maat/heart/tbox/cvs-gcc/gcc/gcc/c-pretty-print.c:227: warning: ISO C89 does not support the `ll' length modifier
gcc -c   -g -O2 -DIN_GCC -DCROSS_COMPILE  -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wtraditional -pedantic -Wno-long-long  -DHAVE_CONFIG_H    -I. -I. -I/maat/heart/tbox/cvs-gcc/gcc/gcc -I/maat/heart/tbox/cvs-gcc/gcc/gcc/. -I/maat/heart/tbox/cvs-gcc/gcc/gcc/config -I/maat/heart/tbox/cvs-gcc/gcc/gcc/../include /maat/heart/tbox/cvs-gcc/gcc/gcc/attribs.c -o attribs.o
gcc -c   -g -O2 -DIN_GCC -DCROSS_COMPILE  -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wtraditional -pedantic -Wno-long-long  -DHAVE_CONFIG_H    -I. -I. -I/maat/heart/tbox/cvs-gcc/gcc/gcc -I/maat/heart/tbox/cvs-gcc/gcc/gcc/. -I/maat/heart/tbox/cvs-gcc/gcc/gcc/config -I/maat/heart/tbox/cvs-gcc/gcc/gcc/../include /maat/heart/tbox/cvs-gcc/gcc/gcc/c-errors.c -o c-errors.o
gcc -c   -g -O2 -DIN_GCC -DCROSS_COMPILE  -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wtraditional -pedantic -Wno-long-long  -DHAVE_CONFIG_H    -I. -I. -I/maat/heart/tbox/cvs-gcc/gcc/gcc -I/maat/heart/tbox/cvs-gcc/gcc/gcc/. -I/maat/heart/tbox/cvs-gcc/gcc/gcc/config -I/maat/heart/tbox/cvs-gcc/gcc/gcc/../include /maat/heart/tbox/cvs-gcc/gcc/gcc/c-lex.c -o c-lex.o
/maat/heart/tbox/cvs-gcc/gcc/gcc/c-lex.c:102:59: warning: function-like macro "strcmp" must be used with arguments in traditional C
gcc -c   -g -O2 -DIN_GCC -DCROSS_COMPILE  -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wtraditional -pedantic -Wno-long-long  -DHAVE_CONFIG_H    -I. -I. -I/maat/heart/tbox/cvs-gcc/gcc/gcc -I/maat/heart/tbox/cvs-gcc/gcc/gcc/. -I/maat/heart/tbox/cvs-gcc/gcc/gcc/config -I/maat/heart/tbox/cvs-gcc/gcc/gcc/../include /maat/heart/tbox/cvs-gcc/gcc/gcc/c-pragma.c -o c-pragma.o
gcc -c   -g -O2 -DIN_GCC -DCROSS_COMPILE  -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wtraditional -pedantic -Wno-long-long  -DHAVE_CONFIG_H    -I. -I. -I/maat/heart/tbox/cvs-gcc/gcc/gcc -I/maat/heart/tbox/cvs-gcc/gcc/gcc/. -I/maat/heart/tbox/cvs-gcc/gcc/gcc/config -I/maat/heart/tbox/cvs-gcc/gcc/gcc/../include /maat/heart/tbox/cvs-gcc/gcc/gcc/c-decl.c -o c-decl.o
gcc -c   -g -O2 -DIN_GCC -DCROSS_COMPILE  -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wtraditional -pedantic -Wno-long-long  -DHAVE_CONFIG_H    -I. -I. -I/maat/heart/tbox/cvs-gcc/gcc/gcc -I/maat/heart/tbox/cvs-gcc/gcc/gcc/. -I/maat/heart/tbox/cvs-gcc/gcc/gcc/config -I/maat/heart/tbox/cvs-gcc/gcc/gcc/../include /maat/heart/tbox/cvs-gcc/gcc/gcc/c-typeck.c -o c-typeck.o
gcc -c   -g -O2 -DIN_GCC -DCROSS_COMPILE  -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wtraditional -pedantic -Wno-long-long  -DHAVE_CONFIG_H    -I. -I. -I/maat/heart/tbox/cvs-gcc/gcc/gcc -I/maat/heart/tbox/cvs-gcc/gcc/gcc/. -I/maat/heart/tbox/cvs-gcc/gcc/gcc/config -I/maat/heart/tbox/cvs-gcc/gcc/gcc/../include /maat/heart/tbox/cvs-gcc/gcc/gcc/c-convert.c -o c-convert.o
gcc -c   -g -O2 -DIN_GCC -DCROSS_COMPILE  -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wtraditional -pedantic -Wno-long-long  -DHAVE_CONFIG_H    -I. -I. -I/maat/heart/tbox/cvs-gcc/gcc/gcc -I/maat/heart/tbox/cvs-gcc/gcc/gcc/. -I/maat/heart/tbox/cvs-gcc/gcc/gcc/config -I/maat/heart/tbox/cvs-gcc/gcc/gcc/../include /maat/heart/tbox/cvs-gcc/gcc/gcc/c-aux-info.c -o c-aux-info.o
gcc -c   -g -O2 -DIN_GCC -DCROSS_COMPILE  -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wtraditional -pedantic -Wno-long-long  -DHAVE_CONFIG_H    -I. -I. -I/maat/heart/tbox/cvs-gcc/gcc/gcc -I/maat/heart/tbox/cvs-gcc/gcc/gcc/. -I/maat/heart/tbox/cvs-gcc/gcc/gcc/config -I/maat/heart/tbox/cvs-gcc/gcc/gcc/../include /maat/heart/tbox/cvs-gcc/gcc/gcc/c-common.c -o c-common.o
/maat/heart/tbox/cvs-gcc/gcc/gcc/c-common.c: In function `cb_register_builtins':
/maat/heart/tbox/cvs-gcc/gcc/gcc/c-common.c:4763: `clk_objective_c' undeclared (first use in this function)
/maat/heart/tbox/cvs-gcc/gcc/gcc/c-common.c:4763: (Each undeclared identifier is reported only once
/maat/heart/tbox/cvs-gcc/gcc/gcc/c-common.c:4763: for each function it appears in.)
make[1]: *** [c-common.o] Error 1
make[1]: Leaving directory `/anubis/mummy/tbox/mips-elf/build/gcc'
make: *** [all-gcc] Error 2
+ exit 1


------------------------------------------------------------------------
--
Geoffrey Keating <regress@redhat.com>
(via an automated GCC regression-testing script.)
--------------------------------------------------------------
Ziemowit Laski                 1 Infinite Loop, MS 301-2K
Mac OS X Compiler Group        Cupertino, CA USA  95014-2083
Apple Computer, Inc.           +1.408.974.6229  Fax .5477

Follow-Ups:
- Re: PATCH: Follow up to my earlier patch (MIPS/Alpha/Interix)
  - From: Ziemowit Laski

References:
- PATCH: Follow up to my earlier patch (MIPS/Alpha/Interix)
  - From: Ziemowit Laski

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]