This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: cpplib: Start moving switch handling to front ends


Devang Patel wrote:

On Thursday, August 8, 2002, at 03:57 AM, Hans-Peter Nilsson wrote:

On Wed, 7 Aug 2002, Devang Patel wrote:

I am also preparing a patch to introduce one new warning flag,
-Wno-#warnings, to disable #warning messages. Is it a good idea?

Don't use '#' in the name.  That'd require quoting in a shell.
(Perhaps -Wno-hashwarnings?)

I do not care about the name,  but instead of forcing current users
(darwin uses bash and/or tcsh as default shell) to change, it would
be nice if new user uses proper quoting.
The reason it hasn't been a problem for Apple is that PB wraps
doublequotes around all compiler arguments automatically.  If
this were to get out to people using regular make, there would be
a hue and cry about how their build got mangled (# is special to
make too, after all).


Usually people hate to change makefiles for new compiler to just
rename command line option.

Personally I do not have hard opinion about this, but I have not seen
any guide-lines about use of special chars like '#' in warning names.

If everybody thinks, it is not OK then I will change it to -Wno-pound-warnings.
"pound" is somewhat cultural - I think of the char as "sharp" (musical),
and H-P called it "hash".  If we do this, we should use terminology from
the language definition and call it -Wno-warning-directives.

Stan




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]