This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch for various warnings in gcc


ghazi@caip.rutgers.edu said:
> I'm pretty sure your patch isn't correct.  See my comments below. 

Indeed you are right, there is a typo I introduced in this version
(in the previous version I totally suppressed the template_args
variable, but keeping it makes the code clearer).
The template_args initialization should take template_id as argument
instead of fn and once set in the first if template_id is not changed.
The proper patch is thus the one below...

> However you should fully test your patch before posting it.  If that
> works, I would prefer your fix over mine. 

I indeed intented to do a full check of several warning patches that I had
(most of which are a subset of yours), before posting. But since you
were faster than I was, I just sent a fast notice to avoid double work...
Once I'll have bootstrapped/checked the compiler with this patch, I will 
resend it with the proper ChangeLog.

	Theo.

--------------------------------------------------------------------
Theodore Papadopoulo
Email: Theodore.Papadopoulo@sophia.inria.fr Tel: (33) 04 92 38 76 01
 --------------------------------------------------------------------

Attachment: patch-warning
Description: patch-warning


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]