This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] IA-32 bitfields (take 4)


int
rs6000_field_alignment (field, computed)
     tree field;
     int computed;
{
  tree type = get_inner_array_type (field);

  if (DEFAULT_ABI == ABI_V4 && TARGET_ALTIVEC
      && TREE_CODE (type) == VECTOR_TYPE)
    return 128;

  if (TYPE_MODE (type) == DFmode)
    return MIN (32, computed);
  return computed;
}

	The second adjustment needs to be conditional on ABI_AIX or
ABI_DARWIN.  That adjustment does not apply to SVR4 or eABI.  I also would
place an extra line before the final return to make the formatting
clearer:

...
  if ((DEFAULT_ABI == ABI_AIX || DEFAULT_ABI == ABI_DARWIN)
      && TYPE_MODE (type) == DFmode)
    return MIN (32, computed);

  return computed;
}

David


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]