This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] IA-32 bitfields (take 3)


On Wed, Aug 07, 2002 at 08:51:08AM -0700, Aldy Hernandez wrote:
> 
> > >  #define ADJUST_FIELD_ALIGN(FIELD, COMPUTED)				      \
> > > -	((TARGET_ALTIVEC && TREE_CODE (TREE_TYPE (FIELD)) == VECTOR_TYPE)     \
> > > +	((TARGET_ALTIVEC						      \
> > > +	  && TREE_CODE (TYPE_P (FIELD) ? (FIELD) : TREE_TYPE (FIELD))	      \
> > > +	     == VECTOR_TYPE)						      \
> > >  	 ? 128 : COMPUTED)
> > 
> > Anyone notice that this is undefed just a couple lines below?
> > David, Geoff or Aldy, anyone know what's going on here?
> 
> Uhhh, this has got to be some kind of oversight.
> 
> The undef was put there by Law on 11-Aug-97, and then I stoopidly
> defined it above it in 07-Nov-01.
> 
> I'll have to move it and run tests, cuz it's definetely wrong.

Should it be moved for 3.2 already?

Also, shouldn't it really look like other ADJUST_FIELD_ALIGN definitions do,
ie. looking inside arrays and honoring __attribute__((aligned(x)))?

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]