This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix combine.c compilation warnings (take 2)

From: Richard Henderson <rth at redhat dot com>
To: Roger Sayle <roger at eyesopen dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Wed, 3 Jul 2002 12:18:15 -0700
Subject: Re: [PATCH] Fix combine.c compilation warnings (take 2)
References: <20020703105704.D2721@redhat.com> <Pine.LNX.4.33.0207031213100.14830-100000@www.eyesopen.com>

On Wed, Jul 03, 2002 at 12:21:20PM -0600, Roger Sayle wrote:
> My apologies.  I thought your previous comments were a review of
> the entire patch and you were only unhappy with the SUBST_INT hunk.

Somehow I'd thought that was all that was in there and stopped
when I didn't like the first hunk.

> Would you prefer that I commit those parts of the patch that you've
> approved, and submit a separate patch to address the remaining
> warnings based on your comments?

Yes.


r~

Follow-Ups:
- [PATCH] Fix combine.c compilation warnings (take 3)
  - From: Roger Sayle

References:
- Re: [PATCH] Fix combine.c compilation warnings (take 2)
  - From: Richard Henderson
- Re: [PATCH] Fix combine.c compilation warnings (take 2)
  - From: Roger Sayle

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]