This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: CPP built-in cleanup for NetBSD SPARC targets
- From: Jonathan Lennox <lennox at cs dot columbia dot edu>
- To: Jason R Thorpe <thorpej at wasabisystems dot com>, gcc-patches at gcc dot gnu dot org
- Date: Thu, 30 May 2002 00:25:39 -0400
- Subject: Re: CPP built-in cleanup for NetBSD SPARC targets
- References: <20020529164957.D523@dr-evil.shagadelic.org>
Jason R Thorpe wrote:
> +#define TARGET_OS_CPP_BUILTINS() \
> + do \
> + { \
> + NETBSD_OS_CPP_BUILTINS_ELF(); \
> + if (TARGET_ARCH64) \
> + { \
> + NETBSD_OS_CPP_BUILTINS_LP64(); \
> + builtin_define ("__sparc64__"); \
> + builtin_define ("__sparc_v9__"); \
> + } \
> + else \
> + builtin_define ("__sparc"); \
> + builtin_define ("__sparc__"); \
> + } \
> + while (0)
Are the braces really correct on that else clause? You only define __sparc
for 32-bit SPARC, but you define __sparc__ for all SPARC platforms?
If this is really what you meant (and it seems surprising), some explicit
braces, and a comment explaining why, would probably be helpful.
--
Jonathan Lennox
lennox@cs.columbia.edu