This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [3.1.1/mainline] expand_builtin_init_dwarf_reg_sizes fix.


>>>>> "Jan" == Jan Hubicka <jh@suse.cz> writes:

> !   for (i = 0; i < FIRST_PSEUDO_REGISTER; i++)
> !     if (DWARF_FRAME_REGNUM (i) < DWARF_FRAME_REGISTERS)

As long as you're doing this test here,

> !       {
> ! 	HOST_WIDE_INT offset = DWARF_FRAME_REGNUM (i) * GET_MODE_SIZE (mode);
> ! 	HOST_WIDE_INT size = GET_MODE_SIZE (reg_raw_mode[i]);
  
> ! 	if (offset < 0)
> ! 	  continue;

you might as well do this test at the same time, i.e.

if (DWARF_FRAME_REGNUM (i) >= 0
    && DWARF_FRAME_REGNUM (i) < DWARF_FRAME_REGISTERS)

Otherwise, looks fine.

Jason


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]