This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFApproval, trunk] Optimization of Complex OP Real.

From: Richard Henderson <rth at redhat dot com>
To: Toon Moene <toon at moene dot indiv dot nluug dot nl>
Cc: gcc-patches at gcc dot gnu dot org
Date: Thu, 16 May 2002 10:46:27 -0700
Subject: Re: [RFApproval, trunk] Optimization of Complex OP Real.
References: <3CDAC34E.F700651D@moene.indiv.nluug.nl> <3CDAD267.A4BA4AEE@moene.indiv.nluug.nl>

On Thu, May 09, 2002 at 09:47:51PM +0200, Toon Moene wrote:
> + #define COMPLEX_REAL_PART_ZERO_P(REAL, CLASS) ((REAL) == 0 || \
> + 	flag_unsafe_math_optimizations \
> + 		&& (CLASS) == MODE_COMPLEX_FLOAT \
> + 		&& (REAL) == const0_rtx)

Parenthesis problem.  You want

	(((REAL) == 0 || flag_unsafe_math_optimizations)
	 && (CLASS) == MODE_COMPLEX_FLOAT
	 && (REAL) == const0_rtx)

> + #define COMPLEX_IMAG_PART_ZERO_P(IMAG, CLASS) ((IMAG) == 0 || \
> + 	flag_unsafe_math_optimizations \
> + 		&& (CLASS) == MODE_COMPLEX_FLOAT \
> + 		&& (IMAG) == const0_rtx)

I don't see the point of having both of these, since they are
identical.  Also, lets avoid gratuitous macros when we can.
Make this a static inline function.


r~

Follow-Ups:
- Re: [RFApproval, trunk] Optimization of Complex OP Real.
  - From: Toon Moene

References:
- [RFApproval, trunk] Optimization of Complex OP Real.
  - From: Toon Moene
- Re: [RFApproval, trunk] Optimization of Complex OP Real.
  - From: Toon Moene

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]