This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] Convert a29k to new target CPP builtins


On Fri, May 10, 2002 at 07:59:08AM +0100, Neil Booth wrote:
> -#ifdef TARGET_REGISTER_CPP_BUILTINS
> -  TARGET_REGISTER_CPP_BUILTINS;
> +#ifndef TARGET_OS_CPP_BUILTINS
> +# define TARGET_OS_CPP_BUILTINS
>  #endif
> +#ifndef TARGET_CPU_CPP_BUILTINS
> +# define TARGET_CPU_CPP_BUILTINS
> +#endif
> +  TARGET_CPU_CPP_BUILTINS
> +  TARGET_OS_CPP_BUILTINS

Style complaint: Please make these function-like macros for which the
caller is expected to provide a trailing semicolon.  Doing otherwise
confuses automatic indentation programs.

Also, I would suggest that the default definitions belong in
defaults.h or c-common.h.

zw


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]