This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFA: Ignore DOS end-of-line characters (ctrl-Z) unless -W
- From: Zack Weinberg <zack at codesourcery dot com>
- To: pavenis at lanet dot lv
- Cc: Andris Pavenis <pavenis at latnet dot lv>, djgpp-workers at delorie dot com,Eli Zaretskii <eliz at is dot elta dot co dot il>,Nick Clifton <nickc at cambridge dot redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: Thu, 9 May 2002 09:54:55 -0700
- Subject: Re: RFA: Ignore DOS end-of-line characters (ctrl-Z) unless -W
- References: <3CDA764D.1410.A1F3EA@localhost> <3CDAC9D0.15538.1E838FC@localhost>
On Thu, May 09, 2002 at 07:11:12PM +0300, pavenis@lanet.lv wrote:
> On 9 May 2002 at 8:42, Zack Weinberg wrote:
>
> > On Thu, May 09, 2002 at 01:14:53PM +0300, pavenis@lanet.lv wrote:
> > >
> > > OK. Here it is (tested for DJGPP with 3.1 branch)
> >
> > O_TEXT, not O_BINARY. Also, based on other discussion with Eli, the
> > check should apply to all file descriptors, not just stdin, so please
> > move it below the call to open.
> >
>
> I don't think so.
>
> With O_TEXT we will run into another trouble as length of data in memory will
> be smaller than one in file. As result read_include_file() will complain that
> input file is shorter than expected.
>
> So unless we want to remove that check, O_BINARY must stay there.
>
> Current patch changes mode to O_BINARY in rather specific case when
> one is feeding source in gcc from pipe. For example
> cat foo.c | gcc -c -x c -o foo.o -
> In this case file is opened in text mode by default, and I'm getting
> a warning I mentioned above.
Sorry, I misread !isatty as isatty. This is fine, then.
zw