This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] checking version of rtl flag access macros


> > > -/* 1 if insn is a branch that should not unconditionally execute its
> > > -   delay slots, i.e., it is an annulled branch.  */
> > > -#define INSN_ANNULLED_BRANCH_P(INSN) ((INSN)->unchanging)
> > > +/* 1 in an INSN in the delay slot of a branch insn if an annulling branch
> > > +   should be used.  */
> > > +#define INSN_ANNULLED_BRANCH_P(RTX) (RTL_FLAG_CHECK1((RTX), INSN)->unchanging)

> Your mail to gcc-bugs says that the macro is used with JUMP_INSN.  If

The comment for the macro indicates that the macro is for branch insns.
The code INSN is used for insns that cannot jump.  I believe that the
check should be against both JUMP_INSN and CALL_INSN.

The comment needs to be adjusted as INSN isn't an argument of the macro.

Dave
-- 
J. David Anglin                                  dave.anglin@nrc.ca
National Research Council of Canada              (613) 990-0752 (FAX: 952-6605)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]