This is the mail archive of the
mailing list for the GCC project.
Re: RFA: Ignore DOS end-of-line characters (ctrl-Z) unless -W
- From: Eli Zaretskii <eliz at is dot elta dot co dot il>
- To: Andris Pavenis <pavenis at latnet dot lv>
- Cc: Nick Clifton <nickc at cambridge dot redhat dot com>, djgpp-workers at delorie dot com, gcc-patches at gcc dot gnu dot org
- Date: Wed, 8 May 2002 16:50:09 +0300 (IDT)
- Subject: Re: RFA: Ignore DOS end-of-line characters (ctrl-Z) unless -W
On Wed, 8 May 2002, Andris Pavenis wrote:
> > Gcc will issue a warning message if a source file contains a DOS
> > end-of-file character (ctrl-Z). The patch below silences this
> > warning, unless the -W (extra warnings) switch is used. This will
> > allow source files created under DOS to be compiled without
> > prejudice.
> > May I apply this patch please ?
> For DJGPP (i86-pc-msdosdjgpp) I tried to truncate input after
> Ctrl-Z in gcc/cppfiles.c. ^Z is end-of-file for DOS anyway, so the
> correct action should perhaps be ignoring rest of file.
I agree with Andris: the right thing is to stop reading at the first ^Z
character. (A warning under -W is also okay, I think.)
If ignoring everything after ^Z is somehow a problem, please describe the
situation where that problem happens.
Hmm, does this mean GCC reads files in binary mode? (If not, the library
will stop at the first ^Z, and GCC itself will never see any ^Zs.)