This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: gcj access$0 error



Tom Tromey writes:

> I'm wondering if there is some strange case we need to support, for
> instance a chain like this:
>
>  superclass -> derived inner -> top-level subclass -> inner-derived -> here

I'm taking that `->' is a search path that build_access_to_thisn walks
backward from `here.' I don't see how we would have to get to `derived
inner' from `top-level subclass' (I must say I don't see `->' working
any other way. It would clarify if you had an example.)

But I agree that there might unforseen situations not handled, maybe
by build_access_to_thisn and I'd like to address them.

Meanwhile, your patch seems correct to me and improves things a lot. I
ran some supplemental tests, it shows no regressions and improves the
situation a lot with old snapshots of freenet and tomcat. Please check
it in both the branch and the trunk for the time being (unless your
clarification unravels more changes to be made to it.)

./A






Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]