This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: A support function for loop infrastructure change
- From: law at redhat dot com
- To: Zdenek Dvorak <rakdver at atrey dot karlin dot mff dot cuni dot cz>
- Cc: gcc-patches at gcc dot gnu dot org, gcc-pdo at atrey dot karlin dot mff dot cuni dot cz
- Date: Thu, 07 Mar 2002 18:31:14 -0700
- Subject: Re: A support function for loop infrastructure change
- Reply-to: law at redhat dot com
In message <20020308005819.GA23848@atrey.karlin.mff.cuni.cz>, Zdenek Dvorak wri
tes:
> Hello.
>
> This function is used several times in new loop infrastructure (and also
> in new loop optimizer) in cfg branch. Bootstrapped on i686 (both mainline
> and branch).
>
> Zdenek Dvorak
>
> Changelog:
>
> * basic-block.h (dfs_enumerate_from): Declare.
> * cfganal.c (dfs_enumerate_from): New.
These may sound like nits, but can you please try to use more descriptive
variable names.
rslt -> result_list
rslt_max -> max_blocks (?)
st->stack
tv->num_blocks_found
What is "data" used for?
Otherwise it looks pretty reasonable.
jeff