This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix for powerpc-linux-gnualtivec

On Wed, 20 Feb 2002, Graham Stott wrote:

> Aldy Hernandez wrote:
> > 
> > >>>>> "Alan" == Alan Matsuoka <alanm@redhat.com> writes:
> > 
> >  > # >     && LEGITIMATE_ADDRESS_INTEGER_P (XEXP (X, 1), 0)            \
> >  > # > !   && (! ALTIVEC_VECTOR_MODE (MODE) || INTVAL (X) == 0)                \
> >  > # >     && (((MODE) != DFmode && (MODE) != DImode)                  \
> >  > # >         || (TARGET_32BIT                                                \
> >  > # > --- 2116,2121 ----
> >  > # >     && INT_REG_OK_FOR_BASE_P (XEXP (X, 0), (STRICT))            \
> >  > # >     && LEGITIMATE_ADDRESS_INTEGER_P (XEXP (X, 1), 0)            \
> >  > # > !   && (! ALTIVEC_VECTOR_MODE (mode)                            \
> >  > # > !       || (GET_CODE (XEXP (X,1)) == CONST_INT && INTVAL (XEXP (X,1)) == 0)) \
> >  > # >     && (((MODE) != DFmode && (MODE) != DImode)                  \
> > 
> > i agree.  This is ok.
> > 
> > thanks for catching it.
> 
> I don't think we need the extra "GET_CODE (XECP (X, 1) == CONST_INT test because
> LEGITIMATE_ADDRESS_INTEGER_P has already validated that XEXP (X, 1) is a CONST_INT.
> 

Franz Sirl mentioned that to me. I'm going to change it when I get a chance. 

Alan Matsuoka
GCC Engineering
Red Hat Canada, Ltd
mailto:alanm@redhat.com Tel: (416) 482-2661 x250 / Fax: (416) 482-6299
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]