This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH / RFA]: Load hoisting fix
- From: Mark Mitchell <mark at codesourcery dot com>
- To: David Edelsohn <dje at watson dot ibm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 19 Dec 2001 16:03:18 -0800
- Subject: Re: [PATCH / RFA]: Load hoisting fix
--On Wednesday, December 19, 2001 11:08:08 AM -0500 David Edelsohn
> With my last message I did not make it clear that I was submitting
> the patch for approval. As mentioned yesterday, the patch has been
> bootstrapped on both powerpc-ibm-aix22.214.171.124 and i686-pc-linux-gnu with no
> new regressions. This fixes the divconst-3.c regressions on AIX.
The patch is OK, but I would prefer that you create a macro REGNO_NREGS
that encapsulates the cacluation of the number of registers corresponding
to a register. That way everyone else doesn't have to remember *how*
to do the calculation (even though they still have to remember that they
need to *do* it).
Patch pre-approved with that change.
Mark Mitchell firstname.lastname@example.org
CodeSourcery, LLC http://www.codesourcery.com