This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH Re: mangling of '$' / DOLLARS_IN_IDENTIFIERS cleanup
- From: Bryce McKinlay <bryce at waitaki dot otago dot ac dot nz>
- To: Richard Henderson <rth at redhat dot com>
- Cc: Adam Megacz <gcc at lists dot megacz dot com>, gcc-patches at gcc dot gnu dot org, java-patches at gcc dot gnu dot org, neil at daikokuya dot demon dot co dot uk
- Date: Fri, 07 Dec 2001 16:02:01 +1300
- Subject: Re: PATCH Re: mangling of '$' / DOLLARS_IN_IDENTIFIERS cleanup
- References: <86pu5utqi5.fsf@megacz.com> <3C0D88C9.4060004@waitaki.otago.ac.nz> <20011206095802.A9416@redhat.com>
Richard Henderson wrote:
>On Wed, Dec 05, 2001 at 03:39:05PM +1300, Bryce McKinlay wrote:
>
>>The problem seems to stem from Java assuming that NO_DOLLAR_IN_LABEL
>>meant that the target didn't support dollars in labels, which isn't
>>actually the case.
>>
>
>It's supposed to be the case. Unfortunately, Linux (and perhaps
>some others) defined NO_DOLLAR_IN_LABEL in order to preserve
>mangling compatibility with previous versions of gcc.
>
>Given that the current mangler doesn't look at this at all, we
>should just fix those places that incorrectly define NO_DOLLAR_IN_LABEL.
>
Even if that change is made Java would still be broken for a target
which does define NO_DOLLAR_IN_LABEL. Perhaps it doesn't matter - I
suspect that targets which both don't accept "$" and can run libjava are
non-existant, since we've always used $ in other labels and havn't had
any complaints.
Also c++ actually does appear to depend on NO_DOLLAR_IN_LABEL, see
cp/cp-tree.h. The definitions in there still seem to be in use. This is,
I think, the only place where NO_DOLLAR_IN_LABEL is ever used, so its
ain't right for Java to be looking at it when the other front ends don't.
regards
Bryce.