This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Remove mem checking code
- From: kenner at vlsi1 dot ultra dot nyu dot edu (Richard Kenner)
- To: aldyh at redhat dot com
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 6 Dec 01 14:32:27 EST
- Subject: Re: Remove mem checking code
> This breaks ARGS_GROW_DOWNWARD targets. There's a missing ) in the
> line you changed.
> Ooops, sorry. Will fix.
Which begs the question-- what testing *did* you do before you checked
your patch in?
I tested it on a target that doesn't define ARGS_GROW_DOWNWARD,
obviously. Most targets don't define that. Only five do: 1750a, c4x,
dsp16xx, pa, and pj.
This is why languages such as Ada forbid conditional compilation and why
GCC is trying to move towards testing these in "if" statements and not
in the preprocessor.
Luckily, this got caught relatively quickly and was a one-character typo,
but it's easy to see cases where it the relevant symbol might be defined
only on very obscure machines.