This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: gcc told me to report a bug
- From: Nicola Pero <nicola at brainstorm dot co dot uk>
- To: Neil Booth <neil at daikokuya dot demon dot co dot uk>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 6 Dec 2001 10:50:56 +0000 (GMT)
- Subject: Re: gcc told me to report a bug
> > -
> > + else if (code == ENUMERAL_TYPE)
> > + {
> > + charType = 'i';
> > + }
> > else
> > - abort ();
> > + {
> > + abort ();
> > + }
>
> I'm picking nits, but the GNU coding standards mandate no braces here.
> Since the rest of GCC follows this pretty well, I'd appreciate it if
> your patch did too.
Ok - fine - I'll avoid the braces here -
+ else if (code == ENUMERAL_TYPE)
+ charType = 'i';
(picking nits myself, I don't think the GNU coding standards particularly
enforce that it's forbidden to put braces there :-) - they certainly say
they are compulsory in other cases :-) - but I don't think it really
matters - if the rest of GCC doesn't use braces in these cases, you're
right I should follow the GCC convention.)