This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix for regression in gcc.c-torture/execute/20011114-1.c


On Dec  4, 2001, Richard Henderson <rth@redhat.com> wrote:

> On Tue, Dec 04, 2001 at 02:44:29PM -0200, Alexandre Oliva wrote:
>> On Dec  2, 2001, Alexandre Oliva <aoliva@redhat.com> wrote:
>> 
>> > 	* tree.c (get_callee_fndecl): Follow DECL_ABSTRACT_ORIGIN if
>> > 	DECL_INITIAL is NULL.
>> 
>> FYI, it turned out that it was not my other volatile MEM patch that
>> broke C++, but this one.  C++ cdtors often have DECL_ABSTRACT_ORIGIN
>> and !  DECL_INITIAL, but they have nothing to do with inline functions
>> and, in fact, they point to internal decls with illegal names.  We
>> must not follow such ABSTRACT_ORIGINS.

> I think this is a clue that the previous patch is just wrong.
> If you patch around this problem, then we'll have a nice little
> house of cards.

I disagree.  The documentation of DECL_ABSTRACT_ORIGIN supports the
use I'm making of it.  If something else breaks because of this
choice, it's this something else that should be fixed.  Or perhaps the
documentation.

-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                  aoliva@{cygnus.com, redhat.com}
CS PhD student at IC-Unicamp        oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist    *Please* write to mailing lists, not to me


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]