This is the mail archive of the
mailing list for the GCC project.
Re: Clarify rules for testing patches
- From: Gerald Pfeifer <pfeifer at dbai dot tuwien dot ac dot at>
- To: Zack Weinberg <zack at codesourcery dot com>
- Cc: "Joseph S. Myers" <jsm28 at cam dot ac dot uk>, <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 5 Dec 2001 15:30:15 +0100 (CET)
- Subject: Re: Clarify rules for testing patches
On Tue, 4 Dec 2001, Zack Weinberg wrote:
> Here it is. There are still some typo fixes, I'll split them out if
> the text changes need more revision.
Given the feedback, I believe it's better to split.
All pure markup and language fixes...
> Index: contribute.html
> +++ contribute.html 2001/12/04 18:11:00
> @@ -11,7 +11,7 @@
> <p>We strongly encourage contributions of code, bugfixes, new
> optimizations, new features, documentation updates, web page
> -improvements, etc. for GCC</p>
> +improvements, etc. for GCC.</p>
> -the relevant forms. Note that it's a good idea to put
> -<a href="mailto:firstname.lastname@example.org">email@example.com</a> in copy with
> +the relevant forms. Note that it's a good idea to send <a
> +href="mailto:firstname.lastname@example.org">email@example.com</a> a copy of
> your request.</p>
...and this are fine.
> +<p>Documentation changes do not require a bootstrap, but you must
> +perform <code>make info</code> and <code>make dvi</code> and
> +correct any errors. (You may ignore complaints about overfull or
> +underfull hboxes from <code>make dvi</code>.)</p>
This change (and the related change to cvswrite.html) as well as simply
*moving* the other testing-related information from cvswrite.html is
> +<p>Changes to the web site must <a
> +href="http://validator.w3.org/">validate</a> as XHTML 1.0
> +Transitional. The web pages as checked into CVS do not include
> +DOCTYPE declarations; they are automatically added when the web
> +server checks out its copy. To validate your changes,
> +temporarily insert this header in place of the <html> tag,
> +then use the "upload file" mode of the validator.</p>
> +<?xml version="1.0" encoding="ISO-8859-1"?>
> +<!DOCTYPE html
> + PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
> + "DTD/xhtml1-transitional.dtd">
> +<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
...as is this...
> <h2>Web pages</h2>
> -<p>Note that when you check in changes to our web pages, these will
> -automatically be checked out into the web server's data area.</p>
> +<p>When you check in changes to our web pages, they will automatically
> +be checked out into the web server's data area.</p>
> <dt>Global write permission.</dt>
> - <dd><p>A very limited number of developers have global write permission
> - over the entire repository.</p></dd>
> - <dt>Localized write permission.</dt>
> - <dd><p>This is for people who have primary responsibility for ports,
Please submit these changes separately (and avoid changes which just
consist of reformatting).
(I hope I didn't miss anything.)
Gerald "Jerry" firstname.lastname@example.org http://www.dbai.tuwien.ac.at/~pfeifer/